feat(py): generic datasources improvements re-submit #26 from Nick #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chendaniely
changed the title
chore: add pytest in pyproject toml, but uses current tool.uv table tests: oops put test code in wrong file
chendaniely
force-pushed
the
py-optimize-sql
branch
from
817a8b6 to
1b68325
Compare
|
This LGTM! Once merged I'll merge main into #28 so that'll merge smoothly as well |
|
#28 includes the same optimizations -- I'd suggest we close this PR and consolidate all discussion around that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combining commits from #26:
374bdfb
e294b1b
b179ea6
2cbe199
fixes the conflicts in #29 by overwriting the files from what @npelikan changed.
there might be a conflict if #30 gets merged in before this one because of the PEP 735 dependency groups table change (from
tools.uvtable) in 6a65e69